Git Version | Version Git
Subscription date : 30 November 2007
Messages : 17118
|
it's not yet perfect, but already quite useful  |
|
matttbe, Friday 29 March 2013 à 22:41
|
|
Subscription date : 24 January 2009
Messages : 12573
|
Thank you for these new features!! It's really useful! 
As you said, the design can maybe be improved but it's already really great! |
Subscription date : 30 November 2007
Messages : 17118
|
especially I can't find a way to align the entry on the left
maybe you can find a way to do that ? |
|
lylambda, Saturday 30 March 2013 à 01:06
|
|
Subscription date : 06 September 2009
Messages : 1635
|
I like it too !
The misalignment don't disturb me. That's create difference with each usual menu. |
|
matttbe, Saturday 30 March 2013 à 18:46
|
|
Subscription date : 24 January 2009
Messages : 12573
|
@fabounet: why did you move the use of cd_append_tree_in_menu function from _load_trees_async (CairoDockGetDataAsyncFunc) to _make_menu_from_trees (CairoDockUpdateSyncFunc) => rev 2788
I explained why I think it's maybe better to use cd_append_tree_in_menu in the async function on the commit message of the rev 2773:GMenu: preload: the preload of all icons should not be launched in the mainloop (with a g_idle) because when preloading these icons, the dock lag during a few seconds...
There are two solutions: remove this feature or try to load it in a thread (this is my solution)
When I tried to use gtk_widget_get_preferred_size in a new thread, I had a few crashes in GTK3...
Now the menu is created (cd_append_tree_in_menu + cd_populate_menu_from_directory) with all elements in the thread (and it will also preload all icons if needed) And about cd_append_tree_in_menu :it will populate menu and create all things => It will read all .desktop files: it can take a lot of time if the hard disk is busy at this time (what we have at startup)
(it will have a look at new images and maybe preload them (=> if the corresponding option is enabled)) |
|
fabounet, Saturday 30 March 2013 à 21:15
|
|
Subscription date : 30 November 2007
Messages : 17118
|
I think I wanted to test the difference, and pushed it with the rest
I'm a bit concerned of using gtk in a thread (we already had some problems before)
if the icons are not loaded on startup, building the menu without loading the icons shouldn't be that heavy, maybe we can do that and just let the icons load when they are mapped ? |
|
matttbe, Saturday 30 March 2013 à 23:44
|
|
Subscription date : 24 January 2009
Messages : 12573
|
I'm a bit concerned of using gtk in a thread (we already had some problems before) Yes but it should be supported by GTK (and we had problem before because GTK was not initialised correctly ^^)
if the icons are not loaded on startup, building the menu without loading the icons shouldn't be that heavy I'm not sure that it's not heavy to read all .desktop files and to look for the right icon files when the hard disk is busy. But note that with libgnome-menu-3, if the icons are not preloaded before, it's not so slow to display the menu with the right icons because (I think) these icons just need to be mapped with the files that have already been found.
So my problem here is mainly to load all desktop files and find the right icon file (and not to map all images). Currently, the dock freezes during more than 2 or 3 seconds at startup...
PS: but note that if I try to launch a thread at the end of the previous one to just map all images after, I had random crashes. But I never had crash when mapping images directly after having created the icon. |
Git Version | Version Git
|
English
Online users :