Home Forums Wiki Doc Install Extras Screenshots Source Code Projects Blog Users Groups Register
Glx-Dock / Cairo-Dock List of forums Git Version | Version Git [Fixed] Gnome-Shell: do not disable dash by default
The latest stable release is the *3.4.0* : How to install it here.
Note: We just switched from BZR to Git on Github! (only to host the code and your future pull requests)
Git Version | Version Git

Subjects Author Language Messages Last message
[Locked] [Fixed] Gnome-Shell: do not disable dash by default
Page : 1 2
matttbe English 22 matttbe [Read]
07 April 2013 à 09:30

matttbe, Friday 22 March 2013 à 10:32


Subscription date : 24 January 2009
Messages : 12573
Hello,

Before the 3.2 version, I think a feature should be configurable and disabled by default: the dock should not hide Gnome-Shell's dash by default.
This is a request by Michael on Google Plus: https://plus.google.com/u/0/102647860413217992628/posts/ej34k2uQCD2

I think that the dock should not modify the environment (except with the Cairo-Dock session) even more if the user is not warned

fabounet, Friday 22 March 2013 à 12:02


Subscription date : 30 November 2007
Messages : 17118
I personally think it should, because the "dash" doesn't offer anything that the dock doesn't, so it's just redundancy.

matttbe, Friday 22 March 2013 à 12:06


Subscription date : 24 January 2009
Messages : 12573
Maybe but it's not a reason to modify the behaviour of other programs.

And I think it's the main feature of Gnome-Shell, we can't disable it without the approbation of the user.

PS: I'm on IRC

fabounet, Friday 22 March 2013 à 13:27


Subscription date : 30 November 2007
Messages : 17118
but there is the same feature in the dock, so it's redundant
what's the point in using cairo-dock if you use the dash ?

anyway, it's easy to unhide it with a simple dbus command

matttbe, Friday 22 March 2013 à 13:54


Subscription date : 24 January 2009
Messages : 12573
but there is the same feature in the dock, so it's redundant
Yes, this is why we have to propose to hide it but we can't force it. (I think).
This is just that we change the behaviour of other programs, it's not common and hard to know why Gnome-Shell has changed. I can understand that most users will think that there is a bug in Gnome-Shell.

anyway, it's easy to unhide it with a simple dbus command
But it's really not easy to know that the dash is hidden by the dock and to find the right DBus command!

fabounet, Friday 22 March 2013 à 18:55


Subscription date : 30 November 2007
Messages : 17118
everybody hates the dash anyway, so I think we're fine
but really, there's no point of having 2 docks with one giving absolutely nothing that the other doesn't have (except if the taskbar is not enabled)

Guest, Sunday 31 March 2013 à 19:47

You really should not mess with how other program work (meaning hiding the gnome shell dash). You thing the gnome dash is reduntant to the function of cairo dock, so you disable it. That's fine, but don't force that onto other users. It's not even optional at the moment.

You say it's easy to unhide the dash with a simple dbus command. I disagree: First you have to know that cairo dock removed that dash, then you have to know what dbus is and how to use it, and then, you have to know the right dbus command.

Essentially, what you are doing right now, is breaking the functionality of gnome and then telling users to fix it themselves if they don't like it. Why breaking it in the first place?

fabounet, Sunday 31 March 2013 à 20:45


Subscription date : 30 November 2007
Messages : 17118
why would you use the dash in the first place, considering that the dock already fulfils the exact same task ?

or conversely, why using Cairo-dock as a taskbar if you prefer using Gnome-shell ?

matttbe, Sunday 31 March 2013 à 21:21


Subscription date : 24 January 2009
Messages : 12573
why would you use the dash in the first place, considering that the dock already fulfils the exact same task ?

or conversely, why using Cairo-dock as a taskbar if you prefer using Gnome-shell ?
For me, this is not the problem.

This Gnome-Shell dash is not above the dock (it only appears when displaying the Gnome-Shell "Menu") and it's just redundant... so I don't see why we have to force this behaviour... As the guest said, the dock really should not mess with how other program work (except if it's really needed because it's annoying but it's not the case here).

Some people are using the dock with Unity... Personally, I think it's not interesting to use two taskbars and two docks (which are here visible at the same time!) and this is why I think it's really great to have options to fix this problem (with the Cairo-Dock session and with the possibility to disable Compiz's Unity plugin thanks to the Help applet). But I think it's not a good idea to automatically disable the Unity plugin (the dock doesn't do that ) or to automatically hide Gnome-Shell's dock.

So I think this "feature" (about the Gnome-Shell dash) should be disabled by default and a menu entry should be added in the Help applet to disable this Gnome-Shell dash.

fabounet, Sunday 31 March 2013 à 23:56


Subscription date : 30 November 2007
Messages : 17118
Unity dock and the 'dash' are quite different
the dash doesn't offer more than a taskbar, which is already provided by the dock.
Unity dock can bring some features, and if we have a cairo-dock session, it's precisely to not have this Unity dock
I don't think we "mess" with gnome-shell, but rather than we improve it (see it as a plug-in of GS)

matttbe, Monday 01 April 2013 à 11:29


Subscription date : 24 January 2009
Messages : 12573
the dash doesn't offer more than a taskbar, which is already provided by the dock.
I don't think we "mess" with gnome-shell, but rather than we improve it (see it as a plug-in of GS)
Maybe or maybe not, this is not the question I think... The dock can't change the behaviour of other programs! It's the goal of the Help applet to propose such actions but I think it's not a good idea to force this new behaviour!

Just imagine Gnome-Shell devs (or devs of Unity, Compiz, Gnome-Panel, etc.) who decide now to hide all other windows with 'dock' type just because they (or the designers) think other docks are useless and annoying because they already have a taskbar. Or other programs which change settings of Cairo-Dock just to have smaller icons or to move the dock to another side: the user will think it's a bug in Cairo-Dock and it's hard to know how to revert this change...

Another example: we can't force the display of icons in all GTK Menus (by default, Gnome designers have hidden these icons in all GTK Menus). Yes, we can display these icons in Cairo-Dock's menus and propose an option to display these icons in all menu (in the Help applet) but we can't automatically display these icons in all GTK programs because we think it's better to have these icons... We can propose such actions but we can't automatically enable them.

lylambda, Monday 01 April 2013 à 18:00


Subscription date : 06 September 2009
Messages : 1635
It's seem a lot of people think that's a bug : http://forum.ubuntu-fr.org/viewtopic.php?pid=13091641
IMHO, disactivate a functionality without a big indication isn't a good idea. Explain the situation with a tip can be enough ? Otherwise, matttbe's opinion convince me.

matttbe, Monday 01 April 2013 à 18:32


Subscription date : 24 January 2009
Messages : 12573
I'm proposing this patch:
=== modified file 'Help/src/applet-notifications.c'
--- Help/src/applet-notifications.c    2013-02-02 23:32:34 +0000
+++ Help/src/applet-notifications.c    2013-04-01 16:29:05 +0000
@@ -23,+23,@@
 
#include "cairo-dock-struct.h"
 #include "cairo-dock-gui-backend.h"
 #include "implementations/cairo-dock-compiz-integration.h"
+#include "implementations/cairo-dock-gnome-shell-integration.h"
 #include "applet-struct.h"
 #include "applet-tips-dialog.h"
 #include "applet-composite.h"
@@ -266,+267,@@
         
CD_APPLET_ADD_IN_MENU_WITH_STOCK (D_("Disable the gnome-panel"), GTK_STOCK_REMOVE_cd_remove_gnome_panelCD_APPLET_MY_MENU);
     if (
_is_unity_running ())
         
CD_APPLET_ADD_IN_MENU_WITH_STOCK (D_("Disable Unity"), GTK_STOCK_REMOVE_cd_remove_unityCD_APPLET_MY_MENU);
+    if (
cd_gnome_shell_is_running ())
+        
CD_APPLET_ADD_IN_MENU_WITH_STOCK (D_("Disable Gnome-Shell's dock (dash)"), GTK_STOCK_REMOVEcd_gnome_shell_hide_dock_dashCD_APPLET_MY_MENU);
     
CD_APPLET_ADD_IN_MENU_WITH_STOCK (D_("Help"), GTK_STOCK_HELP_cd_show_help_guiCD_APPLET_MY_MENU);
     
CD_APPLET_ADD_IN_MENU_WITH_STOCK (D_("Online help"), GTK_STOCK_HELP_cd_show_help_onlineCD_APPLET_MY_MENU);
 
CD_APPLET_ON_BUILD_MENU_END

=== modified file 'src/implementations/cairo-dock-gnome-shell-integration.c'
--- src/implementations/cairo-dock-gnome-shell-integration.c    2013-03-22 17:55:01 +0000
+++ src/implementations/cairo-dock-gnome-shell-integration.c    2013-04-01 16:26:20 +0000
@@ -115,12 +115,@@
             
CD_GS_OBJECT,
             
CD_GS_INTERFACE);
         
-        if (
myTaskbarParam.bShowAppli)
-            
dbus_g_proxy_call_no_reply (s_pGSProxy"Eval",
-                
G_TYPE_STRING"Main.overview._dash.actor.hide();",
-                
G_TYPE_INVALID,
-                
G_TYPE_INVALID);  // hide the dash, since it's completely redundant with the dock ("Main.panel.actor.hide()" to hide the top panel)
-        
         
_register_gs_backend ();
     }
     else if (
s_pGSProxy != NULL)
@@ -
148,+142,17 @@
         (
CairoDockOnAppliPresentOnDbus_on_detect_gs,
         
NULL);
 }
+
+
gboolean cd_gnome_shell_is_running (void)
+{
+    return 
s_pGSProxy != NULL// + check if dash is visible?
+}
+
+
void cd_gnome_shell_hide_dock_dash (void)
+{
+    if (
s_pGSProxy != NULL)
+        
dbus_g_proxy_call_no_reply (s_pGSProxy"Eval",
+            
G_TYPE_STRING"Main.overview._dash.actor.hide();",
+            
G_TYPE_INVALID,
+            
G_TYPE_INVALID);  // hide the dash, since it's completely redundant with the dock ("Main.panel.actor.hide()" to hide the top panel)
+}

=== 
modified file 'src/implementations/cairo-dock-gnome-shell-integration.h'
--- src/implementations/cairo-dock-gnome-shell-integration.h    2013-02-17 01:26:37 +0000
+++ src/implementations/cairo-dock-gnome-shell-integration.h    2013-04-01 16:25:59 +0000
@@ -32,+32,10 @@
 
 
void cd_init_gnome_shell_backend (void);
 
+
gboolean cd_gnome_shell_is_running (void);
+
+
void cd_gnome_shell_hide_dock_dash (void);
+
 
 
G_END_DECLS
 
#endif

PS: I'm proposing this patch mainly because it's something that the dock can't do automatically

matttbe, Tuesday 02 April 2013 à 02:04


Subscription date : 24 January 2009
Messages : 12573
Or we can propose a dialogue at startup to hide this dock/dash if gnome-shell is detected (the first time). (but we can't impose this behaviour to users without their agreement because we are not Gnome-Shell devs... )

Guest, Tuesday 02 April 2013 à 19:16

+1 for making the "breaking of gnome-shell" optional

matttbe, Wednesday 03 April 2013 à 01:03


Subscription date : 24 January 2009
Messages : 12573
@fabounet: thank you for the new rev 1447!
GS integration: hide the dash only when we show the desktops or the windows
(but note that it can be interesting to add an hidden option to not hide Gnome-Shell dash at all. Just something that can be done without modifing any source code )

Guest, Saturday 06 April 2013 à 20:28

I can't believe you idiots would presume to remove a feature from Gnome without asking. Cairo-dock is an addition to Gnome, not the other way around.

Now, is one you cretins going to tell me how to turn this off?

matttbe, Saturday 06 April 2013 à 21:23


Subscription date : 24 January 2009
Messages : 12573
I can't believe you (find the best adjective) are talking like that with people who develop and contribute to free software! This is such a shame! What are you thinking about us? That we try to get money with this? That we're thousand of developers behind this project? That we're working for a big company and it's allowed to injure the company (but here it's clearly injuring people...)???
Maybe this choice was not the best but this is not the reason to say that? Did you ever read the GPL license?
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
I thought that these lines was added only for US companies which want to protect themselves again other companies which always want more money like Apple... But it seems I forget people like you...

I don't know why I give you these links... maybe for other people who read this post => bg_topic.php?t=6825 & Cairo-Dock and Gnome-Shell

It's time for me to stop working... Thank you for this XXX message!

Guest, Saturday 06 April 2013 à 23:42

No, it's better that I think that Gnome broke "for no reason" after upgrading cairo-dock.

Truth is, Gnome is more important to me than your dock. That and knowing I don't have a broken system!

Do what you want, you will anyway.

fabounet, Sunday 07 April 2013 à 01:23


Subscription date : 30 November 2007
Messages : 17118
If only you had taken 30 seconds to read the previous post, which links to the commit number 1447, you would have noticed that the problem is now fixed, and you would have avoided this shameful post.
That being said, we're not developing Cairo-dock for your sole purpose, so feel free to do whatever you want (remember, it's free software, if you can understand the meaning)

Git Version | Version Git

Subjects Author Language Messages Last message
[Locked] [Fixed] Gnome-Shell: do not disable dash by default
Page : 1 2
matttbe English 22 matttbe [Read]
07 April 2013 à 09:30


Glx-Dock / Cairo-Dock List of forums Git Version | Version Git [Fixed] Gnome-Shell: do not disable dash by default Top

Online users :

Powered by ElementSpeak © 2007 Adrien Pilleboue, 2009-2013 Matthieu Baerts.
Dock based on CSS Dock Menu (Ndesign) with jQuery. Icons by zgegball
Cairo-Dock is a free software under GNU-GPL3 licence. First stable version created by Fabounet.
Many thanks to TuxFamily for the web Hosting and Mav for the domain name.